Re: refactor architecture-specific popcount code - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: refactor architecture-specific popcount code
Date
Msg-id aWk65qnA-wD0dOjp@nathan
Whole thread Raw
In response to Re: refactor architecture-specific popcount code  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Here is a new patch set.  Notably, I've added a 0004 that does the
following:

* Removes TRY_POPCNT_X86_64.  We now assume that the required CPUID
intrinsics are available, as we have long done in some of the CRC-32C code.

* Moves the MSVC check for HAVE_X86_64_POPCNTQ to configuration-time.  This
way, we set it for all relevant platforms in one place.

* Moves the #defines for USE_SSE2 and USE_NEON to c.h so that they can be
used elsewhere without simd.h.  Consequently, we can remove POPCNT_AARCH64.

* Moves the #includes for pg_bitutils.h to below the system headers in
pg_popcount_{aarch64,x86}.c (since we no longer depend on macros defined in
pg_bitutils.h).

-- 
nathan

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Proposal to allow setting cursor options on Portals
Next
From: Laurenz Albe
Date:
Subject: Re: Can we change pg_rewind used without wal_log_hints and data_checksums