Re: [PATCH] remove incorrect comment in pg_resetwal.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] remove incorrect comment in pg_resetwal.c
Date
Msg-id aWngdjv3OfcX5-4p@paquier.xyz
Whole thread Raw
In response to [PATCH] remove incorrect comment in pg_resetwal.c  (Gavin LYU <gavin790417@gmail.com>)
Responses Re: [PATCH] remove incorrect comment in pg_resetwal.c
List pgsql-hackers
On Fri, Jan 16, 2026 at 02:45:42PM +0800, Gavin LYU wrote:
> In the block handling the -e option, there’s a comment that appears to be a
> copy-paste error (line 190 and 191). It references a second %s, but none
> exists in that format string. Moreover, similar argument-handling code for
> other options doesn’t include such a comment.
>
> I believe it should be removed.

I disagree.  This note still looks helpful to me when it comes to
translation even if it is incorrect: the %s markup refers to an option
switch.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Simplify code building the LR conflict messages
Next
From: Chao Li
Date:
Subject: Re: fix a spelling mistake