pg_dump should use current_database() instead of PQdb() - Mailing list pgsql-hackers

From Peter Eisentraut
Subject pg_dump should use current_database() instead of PQdb()
Date
Msg-id b6ffa98b-7566-6465-19d5-7e7f3278307c@2ndquadrant.com
Whole thread Raw
Responses Re: pg_dump should use current_database() instead of PQdb()
Re: pg_dump should use current_database() instead of PQdb()
List pgsql-hackers
A report from a pgbouncer user revealed that running pg_dump -C/--create
does not work through a connection proxy if the virtual database name on
the proxy does not match the real database name on the database server.
That's because pg_dump looks up the database to be dumped using the
information from PQdb().  It should be using current_database() instead.
 (The code was quite likely written before current_database() was
available (PG 7.3)).

See attached patch.

There are a few other uses of PQdb() in pg_dump, but I think those are
OK because they relate to connection information.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager
Next
From: Tom Lane
Date:
Subject: Re: pg_dump should use current_database() instead of PQdb()