Thank you, pushed
Amit Langote wrote:
> Hi.
>
> On 2018/04/11 0:36, Teodor Sigaev wrote:
>>> Does the attached fix look correct? Haven't checked the fix with
>>> ATTACH
>>> PARTITION though.
>>>
>>>
>>> Attached patch seems to fix the problem. However, I would rather get
>>> rid of modifying stmt->indexParams. That seems to be more logical
>>> for me. Also, it would be good to check some covering indexes on
>>> partitioned tables. See the attached patch.
>>
>> Seems right way, do not modify incoming object and do not copy rather
>> large and deep nested structure as suggested by Amit.
>
> Yeah, Alexander's suggested way of using a separate variable for
> indexParams is better.
>
>> But it will be better to have a ATTACH PARTITION test too.
>
> I have added tests. Actually, instead of modifying existing tests, I
> think it might be better to have a separate section at the end of
> indexing.sql to test covering indexes feature for partitioned tables.
>
> Attached find updated patch.
>
> Thanks,
> Amit
>
--
Teodor Sigaev E-mail: teodor@sigaev.ru
WWW: http://www.sigaev.ru/
