Re: 001_password.pl fails with --without-readline - Mailing list pgsql-hackers

From Oleg Tselebrovskiy
Subject Re: 001_password.pl fails with --without-readline
Date
Msg-id c19ac5e530c27b69ded0c8efcc581772@postgrespro.ru
Whole thread Raw
In response to Re: 001_password.pl fails with --without-readline  (Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru>)
List pgsql-hackers
The easiest way to fix 030_pager.pl is to just replace ' ' with '*'
in regex. With readline, everything that we look for is placed on
its own line so we don't break anything, but --without-readline
produces the following output (with some hand-written debug info):

    IPC::Run 0000 [#2(438962)]: ** pumping
    IPC::Run 0000 [#2(438962)]: read( 11 ) = 4 chars '39
    IPC::Run 0000 [#2(438962)]: '

    stream:postgres=# \pset expanded
    SELECT generate_series(1,20) as g;
    Expanded display is on.
    postgres=# 39

So the output that is turned on with IPCRUNDEBUG=data shows us "we got
only 4 chars, '39\n\0'!", but in reality we have more stuff in stream,
so pump_until() function doesn't match with passed regex

Patch is attached

Regards,
Oleg

Attachment

pgsql-hackers by date:

Previous
From: Jim Jones
Date:
Subject: Re: WIP - xmlvalidate implementation from TODO list
Next
From: Soumya S Murali
Date:
Subject: Re: [PATCH] Expose checkpoint reason to completion log messages.