Re: pgsql: Catalog changes preparing for builtin collation provider. - Mailing list pgsql-committers

From Jeff Davis
Subject Re: pgsql: Catalog changes preparing for builtin collation provider.
Date
Msg-id c7a14f37bd2de4980a4e47c377484f01da8c4d76.camel@j-davis.com
Whole thread Raw
In response to Re: pgsql: Catalog changes preparing for builtin collation provider.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Mon, 2024-03-11 at 18:04 -0400, Tom Lane wrote:

> Another question is why it didn't fail on all the animals with
> similar
> Perl vintage.  My guess about that is that there's some configuration
> difference causing the Perl script to take slightly different code
> paths, but it's just a guess.

Sounds plausible.

>
> Yeah.  I was dismayed to find that there's no perlcritic check for
> this, because it sure seems like the kind of thing you don't want
> to invoke by accident.

Additionally, the delimiters can many characters, which makes simple
grepping harder.

I found a few cases -- attached a patch. Something is better than
nothing. I'm not sure that I got the /.*/ cases right, but they don't
seem to be expecting any output, so /.*/ seemed like the right pattern.

Regards,
    Jeff Davis


Attachment

pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: pgsql: Catalog changes preparing for builtin collation provider.
Next
From: Michael Paquier
Date:
Subject: pgsql: Use printf's %m format instead of strerror(errno) in more places