Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions
Date
Msg-id cc1d70ab-3304-1d2c-9976-0b8cd9ce5fee@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions
List pgsql-hackers
Tree view 
On 07.01.23 08:21, Peter Eisentraut wrote:
> On 23.11.22 14:57, Aleksander Alekseev wrote:
>> Hi Andres,
>>
>> Thanks for the review!
>>
>>> I don't think it is correct for any of these to add const. The only 
>>> reason it
>>> works is because of casting etc.
>>
>> Fair enough. PFA the corrected patch v2.
> 
> This patch version looks correct to me.  It is almost the same as the 
> one that Andres had posted in his thread, except that yours also 
> modifies slist_delete() and dlist_member_check().  Both of these changes 
> also look correct to me.

committed

pgsql-hackers by date:

Previous
From: "Drouvot, Bertrand"
Date:
Subject: Re: Strengthen pg_waldump's --save-fullpage tests
Next
From: Thomas Munro
Date:
Subject: Re: Using WaitEventSet in the postmaster