Re: GUC custom variables broken - Mailing list pgsql-hackers

From Thomas Hallgren
Subject Re: GUC custom variables broken
Date
Msg-id cn0tn2$v3q$1@sea.gmane.org
Whole thread Raw
In response to GUC custom variables broken  (Thomas Hallgren <thhal@mailblocks.com>)
List pgsql-hackers
Thomas Hallgren wrote:
> I have the following in my postgresql.conf
> 
> custom_variable_classes = 'pljava'
> pljava.classpath = 
> 'C:\\Tada\\Workspace\\org.postgresql.pljava\\build\\pljava.jar'
> 
> It worked fine with 8.0.0beta2. The beta4 however, gives me the 
> following message:
> 
>    FATAL:  unrecognized configuration parameter "pljava.classpath"
> 
> What happened?>
Ah, I see what's wrong. It's in the guc_file.l

Previously, the "custom_variable_classes" was *set* first of all 
variables. Now, it's moved first in the linked list and then *tested* 
first of all. Subsequent tests of custom variables will of course then 
fail since the custom_variable_classes has not been set.

Perhaps this change could be reverted? Or perhaps someone has other 
preferences on implementation?

Regards,
Thomas Hallgren



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: GUC custom variables broken
Next
From: Dave Cramer
Date:
Subject: Re: newbie compile question. please help