Re: Add reject_limit option to file_fdw - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Add reject_limit option to file_fdw
Date
Msg-id d7a03664-bef5-49b0-998f-3ea5356b53c9@oss.nttdata.com
Whole thread Raw
In response to Re: Add reject_limit option to file_fdw  (torikoshia <torikoshia@oss.nttdata.com>)
List pgsql-hackers

On 2024/11/11 21:45, torikoshia wrote:
>> Thanks for adding the comment. It clearly states that REJECT_LIMIT can be
>> a single-quoted string. However, it might also be helpful to mention that
>> it can be provided as an int64 in the COPY command option. How about
>> updating it like this?
>>
>> ------------------------------------
>> REJECT_LIMIT can be specified in two ways: as an int64 for the COPY command
>> option or as a single-quoted string for the foreign table option using
>> file_fdw. Therefore this function needs to handle both formats.
>> ------------------------------------
> 
> Thanks! it seems better.
> 
> 
> Attached v3 patch.

Thanks for updating the patch! It looks like you forgot to attach it, though.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Eager aggregation, take 3
Next
From: Jacob Champion
Date:
Subject: Re: Add html-serve target to autotools and meson