On 9/19/25 7:42 AM, David Rowley wrote:
> On Fri, 19 Sept 2025 at 23:05, Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> On 19.09.25 10:22, Álvaro Herrera wrote:
>>> There are two things we could do. One is to simply restrict `git blame`
>>> to authenticated users; this shouldn't be_too_ bad. But if we don't
>>> want that, we could put the bot checker javascript tricks in front of
>>> `blame`. In fact maybe we could have the best of both worlds: you get
>>> the javascript check if you're not authenticated, but nothing if you
>>> are. I'm not sure how easy it is to implement this though.
>>
>> Or just disable git blame. Who needs to run that through the website?
>
> I'd vote for getting rid of the blame if it could buy us back enough
> CPU cycles to have diff working again. I personally miss not having
> diff. I found it convenient when following links to see what's been
> changed from the pgsql-committers list.
With the disclaimer that I'm not the target audience for this work, I've
previously used the "git blame" web feature on git.postgresql.org to
figure some stuff out, but these days I just use the Github one as
Daniel mentioned. I do think the absence of diff is less than ideal, and
definitely something that I use fairly frequently even if I'm not
hacking often.
For the website/patch itself (gitweb vs. cgit), again I'm not the target
audience, so I'll defer to what you all want and particularly want to
ensure your lives are easier. However, with the upcoming traffic spike
with GA, I do want to ensure that our linked things are still working,
which is what prompted the discussion.
Jonathan
