On 30.10.25 07:02, Paul A Jungwirth wrote:
> On Tue, Oct 28, 2025 at 3:49 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>> On 24.10.25 19:08, Paul A Jungwirth wrote:
>>> The first 3 doc patches all apply to features that we released in v18,
>>> so it would be nice to get those reviewed/merged soon if possible.
>>
>> I have looked through the documentation patches 0001 through 0003.
>
> Thanks for taking a look! New patches attached; details below.
>
> Besides addressing your feedback, I corrected a few other details,
> like a discrepancy in the valid-times between the SQL, the diagrams,
> and the SELECT output.
>
>> I suggest making the Temporal Tables chapter a section instead. It
>> doesn't feel big enough to be a top-level topic. I think it would fit
>> well into the Data Definition chapter, perhaps after the "System
>> Columns" section (section 5.6).
>>
>> And then the temporal update and delete material would go into the
>> Data Manipulation chapter.
>
> Okay, done. This separation makes it a little awkward to continue the
> example from the PKs/FKs section, but I included a link and repeated
> the table contents, so I think it is okay. I agree it fits better into
> the existing overall structure.
I committed the patches 0001 and 0002 (from v59).
I massaged it a bit to fit better into the flow of the chapter. For
example, there was already a "products" table mentioned earlier in the
chapter, and I made the new one more similar to that one, so that it can
be seen as an enhancement of what was already discussed. Similarly, I
changed the ALTER TABLE commands into CREATE TABLE, because in the
chapter, the ALTER TABLE commands are not discussed until after the new
section. I also added some <emphasis> to the command examples, similar
to what is done elsewhere. There were some extra blank lines at the
beginning of the image sources (.txt), which did show up as extra top
padding in the SVG output, which didn't seem right. I removed that and
regenerated the images. (Which worked well; I'm glad this pipeline
still worked.)
