Re: Exit walsender before confirming remote flush in logical replication - Mailing list pgsql-hackers

From Andrey Silitskiy
Subject Re: Exit walsender before confirming remote flush in logical replication
Date
Msg-id dcf6a30c-ad28-4644-8523-58f9779156c2@postgrespro.ru
Whole thread Raw
In response to Re: Exit walsender before confirming remote flush in logical replication  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Nov 23, 2025 at 11:46 PM Fujii Masao
<masao(dot)fujii(at)gmail(dot)com> wrote:
 > The difference is that PGC_USERSET also allows per–replication-user
 > overrides when needed, which gives users more flexibility without
 > losing the ability to set a server-wide setting, I think.
 > ...
 > I think there are valid use cases for applying this setting to
 > physical replication as well.
Thanks for the comments. I agree, this parameter also seems usable
for physical replication, if you use it with caution. In this case,
it really becomes useful to be able to configure a parameter for
each connection. I have added these changes to my patch.

Also, earlier I did not mention another difference between my patch
and those discussed earlier. Previously, even in immediate mode,
WalSndCaughtUp flag was checked before calling WalSndDone,
and this made it impossible to shut down even in immediate mode
with WalSndCaughtUp = false when the server has full output buffers.
This does not happen in the current patch implementation. I added
an additional test case for this situation.

Regards,
Andrey Silitskiy
Attachment

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart
Next
From: Nazir Bilal Yavuz
Date:
Subject: Re: meson and check-tests