Re: [PATCH] Magic block for modules - Mailing list pgsql-patches

From Marko Kreen
Subject Re: [PATCH] Magic block for modules
Date
Msg-id e51f66da0605310308j74942a2arbabc485c1129a37f@mail.gmail.com
Whole thread Raw
In response to [PATCH] Magic block for modules  (Martijn van Oosterhout <kleptog@svana.org>)
Responses Re: [PATCH] Magic block for modules
List pgsql-patches
On 5/8/06, Martijn van Oosterhout <kleptog@svana.org> wrote:
> This implements a proposal made last november:
>
> http://archives.postgresql.org/pgsql-hackers/2005-11/msg00578.php

> All it requires is to include the header "pgmagic.h" and to put
> somewhere in their source:
>
> PG_MODULE_MAGIC

Could you serve this as special docstring instead?  Eg:

PG_MODULE(foomodule)

is mandatory, there you can to your magic, and optional:

PG_MODULE_DESC("Do foo")
PG_MODULE_AUTHOR("FooMan <baz@foo>")

This provides more motivation for module authors and also creates
(visually) smooth path to provide automatic install, uninstall and registration:

PG_MODULE_INSTALL(inst_sql)
PG_MODULE_UNINSTALL(uninst_sql)

create module foo from '$libdir/foo';
drop module foo;

This seems like worthwhile direction to move, especially
as it requires pretty small amount of changes.

--
marko

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [PATCH] Add support for GnuTLS
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] psql \copy warning