On 15.01.25 22:15, Nathan Bossart wrote:
> On Wed, Jan 15, 2025 at 03:31:12PM +0100, Peter Eisentraut wrote:
>> On 04.12.24 15:49, Peter Eisentraut wrote:
>>> Here is a patch set in that direction. It renames RowCompareType to
>>> CompareType and updates the surrounding commentary a bit. And then I'm
>>> changing the gist strategy mapping to use the CompareType values instead
>>> of the RT* strategy numbers. Seeing this now, I like this a lot better
>>> than what we have now, because it makes it clearer in the API and the
>>> code what is a real strategy number and what's a different kind of
>>> thing. (This isn't entirely the above-mentioned integration of the gist
>>> support into your patch set yet, but it's a meaningful part of it.)
>>
>> I have committed these, and I'll continue working my way through this patch
>> set now.
>
> cfbot's cpluspluscheck step seems to dislike the new CompareType enum
> declaraction [0]. IIUC that isn't valid in C++.
Fixed, thanks.
