Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document - Mailing list pgsql-hackers

From Daniel Verite
Subject Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
Date
Msg-id ef8b3cbb-724c-41b7-9d00-87fe01c8effc@manitou-mail.org
Whole thread Raw
In response to Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document  (shihao zhong <zhong950419@gmail.com>)
Responses Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
List pgsql-hackers
    shihao zhong wrote:

> Thanks for your comments, a new version is attached.

In this hunk:

@@ -1097,8 +1097,8 @@ WITH ( MODULUS <replaceable
class="parameter">numeric_literal</replaceable>, REM
       method <replaceable>index_method</replaceable>.
       The operators are required to be commutative.
       Each <replaceable class="parameter">exclude_element</replaceable>
-      can optionally specify an operator class and/or ordering options;
-      these are described fully under
+      can optionally specify any of the following: a collation, a
+      operator class, or ordering options; these are described fully under
       <xref linkend="sql-createindex"/>.
      </para>

"a" should be "an" as it's followed by "operator class".

Also the use of "and/or" in the previous version conveys the fact
that operator class and ordering options are not mutually
exclusive. But when using "any of the following" in the new text,
doesn't it loose that meaning?

In case it does, I would suggest the attached diff.

Best regards,
--
Daniel Vérité
https://postgresql.verite.pro/
Twitter: @DanielVerite

Attachment

pgsql-hackers by date:

Previous
From: "Karl O. Pinc"
Date:
Subject: Re: Various small doc improvements; plpgsql, schemas, permissions, oidvector
Next
From: Nurul Karim Rafi
Date:
Subject: Re: Materialized view in Postgres from the variables rather than SQL query results