Request a Demo
Home   >   mailing lists

Re: Allow ON CONFLICT DO UPDATE to return EXCLUDED values - Mailing list pgsql-hackers

From Viktor Holmberg
Subject Re: Allow ON CONFLICT DO UPDATE to return EXCLUDED values
Date
Msg-id fb18cbb9-32ca-46ea-b2ff-a7e7f20e883c@Spark
Whole thread Raw
Responses Re: Allow ON CONFLICT DO UPDATE to return EXCLUDED values
List pgsql-hackers
Tree view
I’ve looked through this patch. As far as I can tell, everything looks good, working and well commented.
The only nitpick I could find is a mispelling "EXLCUDED" → "EXCLUDED" in src/test/regress/expected/returning.out:464.

A maybe bigger question, is it nice that EXCLUDED is null when no conflict occurred? I can see the logic, but I think ergonomics wise it’d be nicer to have the proposed values in EXCLUDED, no matter what happened later. Then one can check EXCLUDED.value = NEW.value to see if one’s changes were added, for example.

/Viktor
On 7 Oct 2025 at 15:43 +0200, Dean Rasheed <dean.a.rasheed@gmail.com>, wrote:
Rebased version attached, following 904f6a593a0.

Regards,
Dean

pgsql-hackers by date:

Previous
From: Nazir Bilal Yavuz
Date:
Subject: Improve docs syntax checking and enable it in the meson build
Next
From: Aleksander Alekseev
Date:
Subject: [PATCH] ecpg: check return value of replace_variables()