Re: Buffer locking is special (hints, checksums, AIO writes) - Mailing list pgsql-hackers

Hi,

On 2026-01-12 12:45:03 -0500, Andres Freund wrote:
> I'm doing another pass through 0003 and will push that if I don't find
> anything significant.

Done, after adjust two comments in minor ways.


> Also working on doing comment polishing of the later patches, found a few
> things, but not quite enough to be worth reposting yet.

Here are the remaining commits, with a bit of polish:

- fixed references to old names in some places (lwlocks, release_ok)

- Aded an assert that we don't already hold a lock in BufferLockConditional()

- typo and grammar fixes

- updated the commit message of the LW_FLAG_RELEASE_OK, as "requested" by
  Melanie. I hope this explains the situation better.

- added a commit that renames ResOwnerReleaseBufferPin to
  ResOwnerReleaseBuffer (et al), as it now also releases content locks if held

  I kept this separate as I'm not yet sure about the new name, partially due
  to there also being a "buffer io" resowner.  I tried "buffer ownership" for
  the resowner that tracks pins and locks, but that was long and not clearly
  better.

Greetings,

Andres Freund