Robert Haas <robertmhaas@gmail.com> writes:
> I think these new regression tests are no good, because I doubt that
> the number of recursive calls that can fit into any given amount of
> stack space is guaranteed to be the same on all platforms. I have
> committed the bug fixes themselves, however.
Thanks for commiting the fixes. About the regression tests, I think
you're right, but then I can't see how to include such a test. Maybe you
could add the other one, though?
> I wasn't entirely happy with your proposed documentation so I'm
> attaching a counter-proposal. My specific complaints are (1) telling
> people that event triggers are run in a savepoint seems a little too
> abstract; I have attempted to make the consequences more concrete; (2)
> RAISE EXCEPTION is PL/pgsql specific and not the only possible reason
> for an error; I have attempted to be more generic; and (3) in the
> process of fiddling with this, I noticed that the ddl_command_end
> documentation can, I believe, be made both shorter and more clear by
> turning it into a rider on the previous paragraph.
>
> Comments?
+1 for this version, thanks.
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
