Re: [PATCH] Remove unused #include's in src/backend/commands/* - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] Remove unused #include's in src/backend/commands/*
Date
Msg-id qky3etnj64r7zugj5wpifetfsaqprw4myy3z6eqdcmnrqxsrjp@oxajbtdamq4t
Whole thread Raw
In response to Re: [PATCH] Remove unused #include's in src/backend/commands/*  (Aleksander Alekseev <aleksander@tigerdata.com>)
Responses Re: [PATCH] Remove unused #include's in src/backend/commands/*
List pgsql-hackers
Hi,

On 2025-10-09 16:08:38 +0300, Aleksander Alekseev wrote:
> > > OK, I tried include-what-you-use with a little post-processing script
> > > and the scope of work seems reasonable. I will submit the updated
> > > patch shortly.
> >
> > Here is the updated patch v3.
> 
> Apparently touching collationcmds.c, restricted_token.c and
> fe-auth-oauth.c was a mistake. Here is the corrected patch v4.

Clearly this approach is not bulletproof enough to actually yield something
reliable enough to actually be applied.


> From 81089fdf47561a4a68f80ebe238e8d5a452f7c0b Mon Sep 17 00:00:00 2001
> From: Aleksander Alekseev <aleksander@tigerdata.com>
> Date: Wed, 8 Oct 2025 15:58:38 +0300
> Subject: [PATCH v4] Remove unused #include's
> 
> Author: Aleksander Alekseev <aleksander@tigerdata.com>
> Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
> Reviewed-by: Andres Freund <andres@anarazel.de>

I've not reviewed this.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Greg Burd
Date:
Subject: Re: [PATCH] Add tests for Bitmapset
Next
From: Aleksander Alekseev
Date:
Subject: Re: [PATCH] Remove unused #include's in src/backend/commands/*