Hi,
On 2025-06-30 08:58:21 +0200, Antonin Houska wrote:
> Andres Freund <andres@anarazel.de> wrote:
>
> > On 2025-03-13 11:53:03 +0100, Antonin Houska wrote:
> > > Attached are a few proposals for minor comment fixes.
> >
> > Thanks, applied.
>
> After reading the code a bit more, I noticed that the 'cb_flags' argument of
> PgAioHandleCallbackStage is not really used, at least in the existing
> callbacks. Is there an intention to use it in the future (the patches for
> async write do not seem to indicate so), or is this only a leftover from
> previous versions of the patch?
Thanks for reading through it!
It seemed more symmetric to have it for stage as well as the completion
callback - and I still think that...
> Besides that, I suggest a minor comment fix.
Thanks. Pushed that fix.
Greetings,
Andres Freund
