Hi Alvora,
thanks for your review.
So wha't the next should I do for commit it, because this is my first patch.
Best Regards
liujinyang
发件人：Álvaro Herrera <alvherre@kurilemu.de> 发件时间：2026年1月14日 01:18 收件人：liujinyang <21043272@qq.com> 抄送：pgsql-hackers <pgsql-hackers@lists.postgresql.org> 主题：Re: remove the unneeded header file math.h in binaryheap.c |
On 2026-Jan-13, liujinyang wrote:
> Hi Hackers,
>
> I found in file binaryheap.c， file "math.h" was included, but it is uncessary, so I removed it
> and filing a patch to address the issue.
Fun. This was already unnecessary at commit 7a2fe9bd0371 which
introduced the file. It seems Abhijit had that include in his first
version [1] because he was using floor(). Robert rewrote it later [2]
and replaced that with straight arithmetic, making the include
unnecessary, but forgot to remove it.
[1] https://postgr.es/m/20121114131112.GA27771@toroid.org
[2] https://postgr.es/m/CA%2BTgmobvR7XW9fjj2RNY7sKK-VAG5nahfai_zV51rHVLDNvaBg%40mail.gmail.com
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
