Re: Fix outdated comments for IndexInfo - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Fix outdated comments for IndexInfo
Date
Msg-id 06a0b50c-dee7-46f5-8449-087e767d5849@eisentraut.org
Whole thread Raw
In response to Re: Fix outdated comments for IndexInfo  (Japin Li <japinli@hotmail.com>)
List pgsql-hackers
On 01.05.25 15:47, Japin Li wrote:
> On Thu, 01 May 2025 at 12:13, Peter Eisentraut <peter@eisentraut.org> wrote:
>> On 30.04.25 17:48, Japin Li wrote:
>>> While working on [1], I found outdated comments in IndexInfo.
>>> The attached patch corrects them.
>>> [1]
>>> https://www.postgresql.org/message-id/2A40921D-83AB-411E-ADA6-7E509A46F1E4%40logansw.com
>>
>> Maybe these per-column comments should be moved inline, similar to,
>> for example, ResultRelInfo later in the file.  That would make
>> maintaining them easier.
> 
> Thank you for the review.  The v2 patch set is attached.
> 
> v2-0001 remains unchanged; v2-0002 has been modified according to your feedback.

I have committed your patch 0001 and backpatched it appropriately, so 
that each branch should now have approximately correct comments.  And 
then I have applied your 0002 to master.  Thanks.




pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Fix inconsistency in the pg_buffercache documentation
Next
From: Bertrand Drouvot
Date:
Subject: Re: Fix inconsistency in the pg_buffercache documentation