Re: Comment in preptlist.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Comment in preptlist.c
Date
Msg-id 1214495.1679407296@sss.pgh.pa.us
Whole thread Raw
In response to Comment in preptlist.c  (Etsuro Fujita <etsuro.fujita@gmail.com>)
List pgsql-hackers
Etsuro Fujita <etsuro.fujita@gmail.com> writes:
> While working on something else, I noticed $SUBJECT added by commit 86dc90056:
>  * For UPDATE and DELETE queries, the targetlist must also contain "junk"
>  * tlist entries needed to allow the executor to identify the rows to be
>  * updated or deleted; for example, the ctid of a heap row.  (The planner
>  * adds these; they're not in what we receive from the planner/rewriter.)

> I think that “planner/rewriter” should be parser/rewriter.  Attached
> is a patch for that.

Agreed, obviously a thinko :-(

            regards, tom lane



pgsql-hackers by date:

Previous
From: Brar Piening
Date:
Subject: Re: doc: add missing "id" attributes to extension packaging page
Next
From: "Regina Obe"
Date:
Subject: RE: Ability to reference other extensions by schema in extension scripts