Re: fix ancient typo in transformRelOptions() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: fix ancient typo in transformRelOptions()
Date
Msg-id 1290107.1754431854@sss.pgh.pa.us
Whole thread Raw
In response to Re: fix ancient typo in transformRelOptions()  (Álvaro Herrera <alvherre@kurilemu.de>)
Responses Re: fix ancient typo in transformRelOptions()
Re: fix ancient typo in transformRelOptions()
List pgsql-hackers
=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> On 2025-Aug-05, Nathan Bossart wrote:
>> I noticed that this function has a "namspace" parameter.  The attached
>> patch adds the missing 'e'.

> I have vague recollections of it being this way because of "namespace"
> being a C++ keyword.  (commit is 3a5b77371522, but I don't have energy
> to look for the discussion right now.)

Oh, duh -- if you try cpluspluscheck you'll find it's unhappy.
I didn't locate the discussion of "namspace" either, but I did
notice that de160e2c0 used "nameSpace" for the same purpose.
Maybe we should standardize on that?  It looks less like a typo
than "namspace", for sure.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Convert varatt.h macros to static inline functions
Next
From: Álvaro Herrera
Date:
Subject: Re: fix ancient typo in transformRelOptions()