Re: [HACKERS] [bug fix] Savepoint-related statements terminates connection - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] [bug fix] Savepoint-related statements terminates connection
Date
Msg-id 13854.1504275575@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] [bug fix] Savepoint-related statements terminates connection  (Simon Riggs <simon@2ndquadrant.com>)
Responses Re: [HACKERS] [bug fix] Savepoint-related statements terminates connection
List pgsql-hackers
Simon Riggs <simon@2ndquadrant.com> writes:
> I've added tests to the recent patch to show it works.

I don't think those test cases prove anything (ie, they work fine
on an unpatched server).  With a backslash maybe they would.

> Any objection to me backpatching this, please say.

This patch makes me itch.  Why is it correct for these three checks,
and only these three checks out of the couple dozen uses of isTopLevel
in standard_ProcessUtility, to instead do something else?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: [HACKERS] Upcoming commit fest will begin soon
Next
From: Fabien COELHO
Date:
Subject: Re: [HACKERS] pgbench: Skipping the creating primary keys afterinitialization