Re: effective_cache_size vs units - Mailing list pgsql-hackers

From Tom Lane
Subject Re: effective_cache_size vs units
Date
Msg-id 14040.1166573774@sss.pgh.pa.us
Whole thread Raw
In response to Re: effective_cache_size vs units  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: effective_cache_size vs units
Re: effective_cache_size vs units
Re: effective_cache_size vs units
Re: effective_cache_size vs units
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> Perhaps it would be more effective to clarify the error message?  Right 
> now it just says something to the effect of "invalid integer".  I'd 
> imagine "invalid memory unit: TB" would be less confusing.

+1 on that, but I think we should just accept the strings
case-insensitively, too.  SQL in general is not case sensitive for
keywords, and neither is anything else in the postgresql.conf file,
so I argue it's inconsistent to be strict about the case for units.

Nor do I believe that we'd ever accept a future patch that made
the distinction between "kb" and "kB" significant --- if you think
people are confused now, just imagine what would happen then.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Companies Contributing to Open Source
Next
From: "Thomas H."
Date:
Subject: Re: Release 8.2.0 done, 8.3 development starts