Re: [HACKERS] src/interfaces/libpq shipping nmake-related Makefiles - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] src/interfaces/libpq shipping nmake-related Makefiles
Date
Msg-id 15260.1491842719@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] src/interfaces/libpq shipping nmake-related Makefiles  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [HACKERS] src/interfaces/libpq shipping nmake-related Makefiles
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
>>>> Are these votes for getting rid of both win32.mak and bcc32.mak?

> PFA a patch that does this. Did I miss something? :)

Perhaps we should get rid of the WIN32_ONLY_COMPILER symbol altogether;
given this patch, "#ifdef WIN32_ONLY_COMPILER" could be replaced by
"#ifdef _MSC_VER".

Or maybe rename it to something else --- I'm not sure what, but
I've always found that symbol rather confusing.

Looks good other than that nitpick.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: [HACKERS] max_sync_workers_per_subscription is missing in postgresql.conf
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] tuple-routing and constraint violation error message, revisited