Re: Fix misuse use of window_gettupleslot function (src/backend/executor/nodeWindowAgg.c) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix misuse use of window_gettupleslot function (src/backend/executor/nodeWindowAgg.c)
Date
Msg-id 1687327.1759680301@sss.pgh.pa.us
Whole thread Raw
In response to Fix misuse use of window_gettupleslot function (src/backend/executor/nodeWindowAgg.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Fix misuse use of window_gettupleslot function (src/backend/executor/nodeWindowAgg.c)
List pgsql-hackers
Ranier Vilela <ranier.vf@gmail.com> writes:
> Per Coverity.
> CID 1635309: (#1 of 1): Unchecked return value (CHECKED_RETURN)
> 7. check_return: Calling window_gettupleslot without checking return value
> (as is done elsewhere 8 out of 9 times).

Yeah, the security team's Coverity instance just whined about that
too.  But isn't the correct behavior simply "return -1"?  It looks
to me like a failure should be interpreted as "row doesn't exist,
therefore it's not in frame".

What would be really useful is a test case that reaches this
condition.  That would make it plain what to do.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Next
From: Álvaro Herrera
Date:
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options