Request a Demo
Home   >   mailing lists

Fix misuse use of window_gettupleslot function (src/backend/executor/nodeWindowAgg.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Fix misuse use of window_gettupleslot function (src/backend/executor/nodeWindowAgg.c)
Date
Msg-id CAEudQArGABt_KKhZiwcKD1gYs3AzburecdoVK7hGUjqa7xqrFQ@mail.gmail.com
Whole thread Raw
Responses Re: Fix misuse use of window_gettupleslot function (src/backend/executor/nodeWindowAgg.c)
List pgsql-hackers
Tree view
Hi.

Per Coverity.

CID 1635309: (#1 of 1): Unchecked return value (CHECKED_RETURN)
7. check_return: Calling window_gettupleslot without checking return value (as is done elsewhere 8 out of 9 times).

The function "window_gettupleslot" can fail.

All other calls check the return, In this case it could not be different.

Fix by checking the return and reporting a message to the user,
in case of failure.
The error message, however, I'm not sure if it's ideal.

best regards,
Ranier Vilela

Attachment

pgsql-hackers by date:

Previous
From: Jim Jones
Date:
Subject: Re: We broke the defense against accessing other sessions' temp tables
Next
From: "Euler Taveira"
Date:
Subject: Re: log_min_messages per backend type