Re: reallocing without oom check in pg_regress - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: reallocing without oom check in pg_regress
Date
Msg-id 16E343D8-1754-427B-9158-BAB63CC0DEC1@yesql.se
Whole thread Raw
In response to Re: reallocing without oom check in pg_regress  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> On 23 Feb 2022, at 23:05, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>> In pg_regress we realloc() with the destination and source pointer being equal,
>> without checking for OOM.  While a fairly unlikely source of errors, is there a
>> reason not to use pg_realloc() there for hygiene?
>
> Yeah, looks like oversight to me.

Thanks for confirming, I've pushed this now after taking it for a spin on the
CI just in case.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: document that brin's autosummarize parameter is off by default
Next
From: Simon Riggs
Date:
Subject: Re: Logical insert/update/delete WAL records for custom table AMs