Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Improve code coverage of network address functions - Mailing list pgsql-hackers

From keisuke kuroda
Subject Re: [PATCH] Improve code coverage of network address functions
Date
Msg-id 173804907807.528.6892612759588298489.pgcf@coridan.postgresql.org
Whole thread Raw
Responses Re: [PATCH] Improve code coverage of network address functions
List pgsql-hackers
Tree view 
The following review has been posted through the commitfest application:
make installcheck-world:  tested, failed
Implements feature:       tested, failed
Spec compliant:           tested, failed
Documentation:            tested, failed

Thank you for your patch!

I have confirmed that the coverage improves 
to the expected value（69.7%->83.0%)

source: commit 75eb9766ec201b62f264554019757716093e2a2f(HEAD)
## add with-openssl option for ssltest
./configure --enable-coverage --enable-tap-tests --with-llvm --with-openssl CFLAGS=-O0
make check-world PG_TEST_EXTRA='ssl' -j 4 > /tmp/regress.log
make coverage-html

The new status of this patch is: Ready for Committer

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.
Next
From: Keisuke Kuroda
Date:
Subject: Re: [PATCH] Improve code coverage of network address functions