Re: [BUG FIX]Connection fails with whitespace after keepalives parameter value - Mailing list pgsql-hackers

Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> On 2024/10/01 14:11, Yuto Sasaki (Fujitsu) wrote:
>> Root cause: The method for parsing the keepalives parameter in the useKeepalives
>> function of the libpq library is not appropriate. Specifically, it doesn't
>> account for whitespace following the numeric value.

> Is a connection URL with whitespace, like "tcp:postgresql://localhost:5432/postgres?keepalives=1 & ...",
> considered valid? If not, the issue seems to be that ecpg adds unnecessary whitespace
> to the connection URL, especially after the "&" character.

I agree with Sasaki-san that useKeepalives seems rather bogus: almost
every other place in fe-connect.c uses pqParseIntParam rather than
calling strtol directly, so why not this one?  We might have some
work to do in ecpg as well, though.

            regards, tom lane