Re: notice about costly ri checks (2) - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: notice about costly ri checks (2)
Date
Msg-id 200403050449.i254nw416512@candle.pha.pa.us
Whole thread Raw
In response to notice about costly ri checks (2)  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: notice about costly ri checks (2)
List pgsql-patches
Fabien COELHO wrote:
>
> Dear patchers,
>
> Here is my second and last try of the day.
>
> This patch adds a "notice" at constraint creation time if the referential
> integrity check is to be "costly", that is it cannot use the index due to
> some incompatibility.
>
> The patch was generated with the "difforig" script against the current cvs
> head.
>
> I put much validation which looks fine to me, but it is only me.
>
> I'm not that satisfied with the wording and the content of the error
> message. Any better suggestion would be welcome.

Agreed.  The current text is:

    NOTICE:  costly cross-type foreign key because of component 1

Seems we should say something like:

    NOTICE:  foreign key constraint 'constrname' must use a costly cross-type conversion

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Updated version of contrib/xml (at last)
Next
From: Tom Lane
Date:
Subject: Re: pg_autovacuum patch for 7.4.2 and HEAD