Re: [PERFORM] A Better External Sort? - Mailing list pgsql-hackers

On Tue, Oct 04, 2005 at 05:23:41PM +0200, Martijn van Oosterhout wrote:
> On Tue, Oct 04, 2005 at 03:56:53PM +0100, Simon Riggs wrote:
> > I've been using gcc 3.4 and saw no warning when using either "-Winline"
> > or "-O3 -Winline".
> Ok, I've just installed 3.4 and verified that. I examined the asm code
> and gcc is inlining it. I concede, at this point just throw in -Winline
> and monitor the situation.
> As an aside, the *_getattr calls end up a bit suboptimal though. It's
> producing code like:
>   cmp attlen, 4
>   je $elsewhere1
>   cmp attlen, 2
>   je $elsewhere2
>   ld byte
> here:
> --- much later ---
> elsewhere1:
>   ld integer
>   jmp $here
> elsewhere2:
>   ld short
>   jmp $here
> No idea whether we want to go down the path of hinting to gcc which
> size will be the most common.

If it will very frequently be one value, and not the other values, I
don't see why we wouldn't want to hint? #ifdef it to a expand to just
the expression if not using GCC. It's important that we know that the
value would be almost always a certain value, however, as GCC will try
to make the path for the expected value as fast as possible, at the
cost of an unexpected value being slower.
 __builtin_expect (long EXP, long C)
    You may use `__builtin_expect' to provide the compiler with branch    prediction information.  In general, you
shouldprefer to use    actual profile feedback for this (`-fprofile-arcs'), as    programmers are notoriously bad at
predictinghow their programs    actually perform.  However, there are applications in which this    data is hard to
collect.
    The return value is the value of EXP, which should be an integral    expression.  The value of C must be a
compile-timeconstant.  The    semantics of the built-in are that it is expected that EXP == C.    For example:
 
         if (__builtin_expect (x, 0))           foo ();
    would indicate that we do not expect to call `foo', since we    expect `x' to be zero.  Since you are limited to
integral   expressions for EXP, you should use constructions such as
 
         if (__builtin_expect (ptr != NULL, 1))           error ();
    when testing pointer or floating-point values.

Cheers,
mark

-- 
mark@mielke.cc / markm@ncf.ca / markm@nortel.com     __________________________
.  .  _  ._  . .   .__    .  . ._. .__ .   . . .__  | Neighbourhood Coder
|\/| |_| |_| |/    |_     |\/|  |  |_  |   |/  |_   | 
|  | | | | \ | \   |__ .  |  | .|. |__ |__ | \ |__  | Ottawa, Ontario, Canada
 One ring to rule them all, one ring to find them, one ring to bring them all                      and in the darkness
bindthem...
 
                          http://mark.mielke.cc/