Re: PQParam version 0.5 - Mailing list pgsql-patches

From Alvaro Herrera
Subject Re: PQParam version 0.5
Date
Msg-id 20071205194425.GJ16991@alvh.no-ip.org
Whole thread Raw
In response to PQParam version 0.5  (Andrew Chernow <ac@esilo.com>)
Responses Re: PQParam version 0.5
List pgsql-patches
Andrew Chernow escribió:

> Also changed PQputint8's prototype.  Previously, it was using a void* as
> the value argument, due to a lack of a portable 64-bit type in libpq. We
> found an intersting way around this by using macro and variable argument
> tricks.

I didn't read the patch, but variadic macros are not portable.  FWIW
uint64 should "portable" to all platforms that have it (and it should be
32 bits on platforms that don't), but you have to watch for
INT64_IS_BUSTED.

--
Alvaro Herrera                 http://www.amazon.com/gp/registry/DXLWNGRJD34J
"I suspect most samba developers are already technically insane...
Of course, since many of them are Australians, you can't tell." (L. Torvalds)

pgsql-patches by date:

Previous
From: Andrew Chernow
Date:
Subject: PQParam version 0.5
Next
From: "Merlin Moncure"
Date:
Subject: Re: PQParam version 0.5