Re: PQParam version 0.5 - Mailing list pgsql-patches

From Merlin Moncure
Subject Re: PQParam version 0.5
Date
Msg-id b42b73150712051148vf9fdb25rf7f01750c1c299d2@mail.gmail.com
Whole thread Raw
In response to Re: PQParam version 0.5  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: PQParam version 0.5
List pgsql-patches
On Dec 5, 2007 2:44 PM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> Andrew Chernow escribió:
>
> > Also changed PQputint8's prototype.  Previously, it was using a void* as
> > the value argument, due to a lack of a portable 64-bit type in libpq. We
> > found an intersting way around this by using macro and variable argument
> > tricks.
>
> I didn't read the patch, but variadic macros are not portable.  FWIW
> uint64 should "portable" to all platforms that have it (and it should be
> 32 bits on platforms that don't), but you have to watch for
> INT64_IS_BUSTED.

we don't use variadic macros...just a macro wrapper to a variadic function.

merlin

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: PQParam version 0.5
Next
From: Andrew Chernow
Date:
Subject: Re: PQParam version 0.5