Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w - Mailing list pgsql-committers

From David Fetter
Subject Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w
Date
Msg-id 20100926002916.GA22240@fetter.org
Whole thread Raw
In response to pgsql: Fix another join removal bug: the check on PlaceHolderVars was w  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w
Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w
List pgsql-committers
On Sat, Sep 25, 2010 at 11:04:28PM +0000, Tom Lane wrote:
> Fix another join removal bug: the check on PlaceHolderVars was
> wrong.
>
> The previous coding would decide that join removal was unsafe upon
> finding a PlaceHolderVar that needed to be evaluated at the inner
> rel and then used above the join.  However, this fails to cover the
> case of PlaceHolderVars that refer to both the inner rel and some
> other rels.  Per bug report from Andrus.

The person who found it originally was Kirill (xitology) Simonov.  He
brought it up in IRC. :)

Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Rename git_topo_order -> git_changelog, per discussion.
Next
From: Tom Lane
Date:
Subject: pgsql: Minor improvements to git_changelog.