Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w
Date
Msg-id 201009261236.48805.andres@anarazel.de
Whole thread Raw
In response to Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w  (David Fetter <david@fetter.org>)
List pgsql-committers
On Sunday 26 September 2010 02:29:16 David Fetter wrote:
> On Sat, Sep 25, 2010 at 11:04:28PM +0000, Tom Lane wrote:
> > Fix another join removal bug: the check on PlaceHolderVars was
> > wrong.
> >
> > The previous coding would decide that join removal was unsafe upon
> > finding a PlaceHolderVar that needed to be evaluated at the inner
> > rel and then used above the join.  However, this fails to cover the
> > case of PlaceHolderVars that refer to both the inner rel and some
> > other rels.  Per bug report from Andrus.
>
> The person who found it originally was Kirill (xitology) Simonov.  He
> brought it up in IRC. :)
No, thats a different bug... For one its affecting 8.4 at least as well, for
another its not yet fixed ;-)

Andres

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Still more tweaking of git_changelog.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Add ALTER TYPE ... ADD/DROP/ALTER/RENAME ATTRIBUTE