Re: Patch for removng unused targets - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Patch for removng unused targets
Date
Msg-id 20130624223912.GF4051@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: Patch for removng unused targets  ("Etsuro Fujita" <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: Patch for removng unused targets
List pgsql-hackers
Etsuro Fujita escribió:
> > From: Hitoshi Harada [mailto:umi.tanuki@gmail.com]
>
> > I tried several ways but I couldn't find big problems.  Small typo:
> > s/rejunk/resjunk/
>
> Thank you for the review.  Attached is an updated version of the patch.

Thanks.  I gave this a look, and made it some trivial adjustments.
Attached is the edited version.  I think this needs some more (succint)
code comments:

. why do we want to remove these entries
. why can't we do it in the DISTINCT case
. why don't we remove the cases we don't remove, within adjust_targetlist().

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: GIN improvements part 3: ordering in index
Next
From: Josh Berkus
Date:
Subject: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]