Re: pg_bsd_indent - improvements around offsetof and sizeof - Mailing list pgsql-hackers

From Andres Freund
Subject Re: pg_bsd_indent - improvements around offsetof and sizeof
Date
Msg-id 20160525200734.nuv4ppfbvzj6odeu@alap3.anarazel.de
Whole thread Raw
In response to Re: pg_bsd_indent - improvements around offsetof and sizeof  (Piotr Stefaniak <postgres@piotr-stefaniak.me>)
Responses Re: pg_bsd_indent - improvements around offsetof and sizeof
List pgsql-hackers
On 2016-05-25 22:01:53 +0200, Piotr Stefaniak wrote:
> On 2016-05-25 21:13, Tom Lane wrote:
> > I'd love to see a fix for its brain damage around function pointer typedef formatting, too.
> 
> Show me a few examples and I'll look into it.
> 
> > I'm excited about this too, not least because it suggests that maybe bsdindent isn't quite as opaque as it
appears.
> 
> It's old, hacked on many times over the past few decades and historically
> just a band-aid rather than something designed from the ground up, so it's
> not easy to work with. Which is why I think that a newer tool (like
> ClangFormat) should be considered as a replacement for pg_bsd_indent.

FWIW, I looked at using clang-format at some point, and it looked like
it'd be a number of additional options to make it work for our case
without changing the code layout too much. There seemed limited
enthusiasm from the authors about accepting relevant options.

Andres



pgsql-hackers by date:

Previous
From: Piotr Stefaniak
Date:
Subject: Re: pg_bsd_indent - improvements around offsetof and sizeof
Next
From: Andres Freund
Date:
Subject: Re: Changed SRF in targetlist handling