Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] path toward faster partition pruning - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [HACKERS] path toward faster partition pruning
Date
Msg-id 20171221160619.olg7wh6e6z53evb3@alvherre.pgsql
Whole thread Raw
In response to Re: [HACKERS] path toward faster partition pruning  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: [HACKERS] path toward faster partition pruning
List pgsql-hackers
Tree view 
Just trying to understand the code here; some very minor comments as I
go along.

partition_op_strategy returning int32 looks pretty ugly, and the calling
code is not super-intelligible either.  How about returning a value from
a new enum?

typedef PartClause is missing a struct name, as is our tradition.


> +                 * We don't a <> operator clause into a key right away.

Missing a word there.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: force parallel mode vs CTAS
Next
From: Tom Lane
Date:
Subject: Re: force parallel mode vs CTAS