Re: reorganizing partitioning code (was: Re: [HACKERS] path towardfaster partition pruning) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: reorganizing partitioning code (was: Re: [HACKERS] path towardfaster partition pruning)
Date
Msg-id 20180214202521.tbt7ck565gqtfszx@alvherre.pgsql
Whole thread Raw
In response to Re: reorganizing partitioning code (was: Re: [HACKERS] path towardfaster partition pruning)  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: reorganizing partitioning code
List pgsql-hackers
This is looking attractive.

Please don't #include postgres.h in partcache.h.  That's per policy.

Why do you need to #include parsenodes.h in partcache.h?

I think rewriteManip.h can do with just relcache.h rather than rel.h
(probably partition.h can do likewise)

thanks

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: rqtx
Date:
Subject: [HACKERS] Inserting data into a new catalog table via source code
Next
From: Tom Lane
Date:
Subject: Re: tapeblocks is uninitialized in logtape.c