Re: pg_partition_tree crashes for a non-defined relation - Mailing list pgsql-hackers

Greetings,

* Michael Paquier (michael@paquier.xyz) wrote:
> On Sun, Dec 09, 2018 at 12:49:18PM -0500, Stephen Frost wrote:
> > Looks alright on a quick glance, but shouldn't you also update the
> > comment..?
>
> The comment on HEAD or with the patch is that:
>     /* Only allow relation types that can appear in partition trees. */
>
> This still looks adapted to me.  Or would you reword it because "allow"
> rather implies that an ERROR is returned?  Would you prefer changing it
> something like that perhaps:
> "Return NULL for relation types that do not appear in partition trees."

Yes.

Thanks!

Stephen