Re: pg13: xlogreader API adjust - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg13: xlogreader API adjust
Date
Msg-id 20200515111858.GB212736@paquier.xyz
Whole thread Raw
In response to Re: pg13: xlogreader API adjust  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: pg13: xlogreader API adjust
List pgsql-hackers
On Thu, May 14, 2020 at 02:12:25PM +0900, Kyotaro Horiguchi wrote:
> Good catch!  That's not only for CreateDecodingContet. That happens
> everywhere in the query loop in PostgresMain() until logreader is
> initialized.  So that also happens, for example, by starting logical
> replication using invalidated slot. Checking xlogreader != NULL in
> WalSndErrorCleanup is sufficient.  It doesn't make actual difference,
> but the attached explicitly initialize the pointer with NULL.

Alvaro, are you planning to look at that?  Should we have an open item
for this matter?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions
Next
From: Euler Taveira
Date:
Subject: Re: Problem with logical replication