seemingly useless #include recently added - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject seemingly useless #include recently added
Date
Msg-id 20230425.115748.2130383825066921512.horikyota.ntt@gmail.com
Whole thread Raw
Responses Re: seemingly useless #include recently added
List pgsql-hackers
Hello.

While working on a patch, I noticed that a rcent commit (d4e71df6d75)
added an apparently unnecessary inclusion of guc.h in smgr.h.

The only change made by the commit to the file is the added #include
directive, which doesn't seem to be functioning, and the build
actually suceeds without it.  Moreover, it brings in some
server-related stuff when I incluce smgr.h in storage_xlog.h, causing
compilation issues for pg_rewind.

Should we remove it? Please find the attached patch.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: buffer refcount leak in foreign batch insert code
Next
From: Tom Lane
Date:
Subject: Re: seemingly useless #include recently added