Request a Demo
Home   >   mailing lists

Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Date
Msg-id 20251011.144218.1729318385118014326.ishii@postgresql.org
Whole thread Raw
In response to Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
List pgsql-hackers
Tree view 
>> Also the error is certainly user-facing,
>> so using elog() was quite inappropriate.  It should be ereport with an
>> errcode of (probably) ERRCODE_FEATURE_NOT_SUPPORTED.  Rolling your
>> own implementation of get_func_name() wasn't great either.
> 
> I overlooked the elog() call and "own implementation of
> get_func_name()". Will fix.

Attached is a trivial patch to fix that. I am going to push it if
there's no objection.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
Attachment

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Fix array access (src/bin/pg_dump/pg_dump.c)
Next
From: Chao Li
Date:
Subject: Re: new environment variable INITDB_LOCALE_PROVIDER