On Oct 11, 2025, at 13:42, Tatsuo Ishii <ishii@postgresql.org> wrote:
Also the error is certainly user-facing,
so using elog() was quite inappropriate. It should be ereport with an
errcode of (probably) ERRCODE_FEATURE_NOT_SUPPORTED. Rolling your
own implementation of get_func_name() wasn't great either.
I overlooked the elog() call and "own implementation of
get_func_name()". Will fix.
Attached is a trivial patch to fix that. I am going to push it if
there's no objection.
Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
<v1-0001-Use-ereport-rather-than-elog-in-WinCheckAndInitia.patch>
I just take a quick look at the patch, a tiny comment is:
```
+ char *funcname = get_func_name(fcinfo->flinfo->fn_oid);
```
This can be a “const char *”.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
