Re: remove the unneeded header file math.h in binaryheap.c - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: remove the unneeded header file math.h in binaryheap.c
Date
Msg-id 202601151335.65rrduj65nat@alvherre.pgsql
Whole thread Raw
In response to Re: remove the unneeded header file math.h in binaryheap.c  (Álvaro Herrera <alvherre@kurilemu.de>)
Responses Re: remove the unneeded header file math.h in binaryheap.c
Re: remove the unneeded header file math.h in binaryheap.c
List pgsql-hackers
On 2026-Jan-15, Álvaro Herrera wrote:

> On 2026-01-15, liujinyang wrote:
> > Hi Alvora, 
> > thanks for your review.
> > So wha't the next should I do for commit it, because this is my first patch.
> 
> Nothing.  I'll push it soon, no worries.

BTW how did you notice that the include wasn't necessary?

I looked around to see if there are more unnecessary inclusions of that
header and found a few candidates.  Things still compile and pass tests
for me, but of course they may fail on other platforms.
https://cirrus-ci.com/build/4766393398198272

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

Attachment

pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: how to gate experimental features (SQL/PGQ)
Next
From: Ashutosh Bapat
Date:
Subject: Re: Import Statistics in postgres_fdw before resorting to sampling.