Re: remove the unneeded header file math.h in binaryheap.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: remove the unneeded header file math.h in binaryheap.c
Date
Msg-id 689686.1768490811@sss.pgh.pa.us
Whole thread Raw
In response to Re: remove the unneeded header file math.h in binaryheap.c  (Álvaro Herrera <alvherre@kurilemu.de>)
Responses Re: remove the unneeded header file math.h in binaryheap.c
List pgsql-hackers
=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> I looked around to see if there are more unnecessary inclusions of that
> header and found a few candidates.  Things still compile and pass tests
> for me, but of course they may fail on other platforms.

Yeah ... my recollection is that some of our inclusions of <math.h>,
and also of <limits.h>, were needed because assorted platforms didn't
follow the C/POSIX standards about which headers should provide which
symbols.  Maybe that's all cleaned up now.  I'd worry about Solaris
and AIX as being the most likely stragglers.

Another likely source of obsolete <math.h> usages is in the datetime
code, as a leftover from our old floating-point timestamps.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: remove the unneeded header file math.h in binaryheap.c
Next
From: "Matheus Alcantara"
Date:
Subject: Re: support ALTER COLUMN SET EXPRESSION over virtual generated column with check constraint