Re: [PATCH] Fixed assertion issues in "pg_get_viewdef" - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Fixed assertion issues in "pg_get_viewdef"
Date
Msg-id 218610.1732122405@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Fixed assertion issues in "pg_get_viewdef"  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
"=?gb18030?B?emVuZ21hbg==?=" <zengman@halodbtech.com> writes:
> Thanks for your guidance, you are right, I looked at your patch
> and combined it with the example to generate a new patch,
> which is really better.

I pushed the code fix, but I can't really convince myself that the
test case is worth the cycles it'd eat forevermore.  If we had
a way to reach the situation where there's setops but not any of
the other clauses in a leaf query, perhaps that would be worth
checking ... but we don't.  It's just belt-and-suspenders-too
programming.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Statistics Import and Export
Next
From: Daniel Gustafsson
Date:
Subject: Re: Replace current implementations in crypt() and gen_salt() to OpenSSL